Allow user id lookup via email #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnmerritt
force-pushed
the
user-lookup
branch
from
c9dcc67
to
d4e0e04
Compare
|
Updated when I moved from my sandbox to the real slack I was targetting - finding user ids by going through lists breaks if slack paginates the response so I switched to using the dedicated lookup endpoint and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great utility!
This PR adds support for searching for a user id by their email. Not sure what you want to do about the new integration test but I figured I'd stick in your public github email in it for now.
I'm seeing a bunch of failures on
make testeven w/o my changes, so I assume there must be extra environment needed to run them cleanly. Please let me know if that's not true!