Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependencies in package.json #1

Closed
mliebischer opened this issue Jul 7, 2022 · 2 comments · Fixed by #3
Closed

Outdated dependencies in package.json #1

mliebischer opened this issue Jul 7, 2022 · 2 comments · Fixed by #3

Comments

@mliebischer
Copy link
Contributor

Describe the bug

This addon seems to be broken due to some dependencies on the deprecated addon @eeacms/volto-blocks-form in package.json.

Error:

12Edit.jsx:218 Uncaught TypeError: _plone_volto_registry__WEBPACK_IMPORTED_MODULE_13__.default.settings.richTextEditorPlugins is not iterable

To Reproduce
Steps to reproduce the behavior:

  1. Add addon to your package.json of your Volto installation
"addons": [
  "@rohberg/volto-accordion-block"
],

"dependencies": {
  "@rohberg/volto-accordion-block": "^0.1.0"
}
  1. Start Volto with yarn start
  2. Click on the button to add/edit the content
  3. ERROR

Software:

Tested with Volto 15.12.1 and Plone 6.0.0a4.

Additional information

Since this package is no longer needed anyway, it can simply be removed from the package.json to fix the problem (see this commit ec0536f#diff-c986a9cd783848dd4ad769e1c52106d0e024a019daa2c4a3cb0d1875551bf8e0L8)

@ksuess
Copy link
Member

ksuess commented Jul 7, 2022

You may want to have a look at https://github.com/eea/volto-accordion-block. It is far more elaborated, as the accordion items can contain blocks.
I should mark this repo as superseeded and archived. Sorry for the inconvenience.

mliebischer added a commit to plone/training that referenced this issue Jul 7, 2022
The example code for the faq block type was outdated. Those are the same fixes as in rohberg/volto-accordion-block#1
@mliebischer
Copy link
Contributor Author

Hi Katja, there is nothing to apologize for. :-) This is a nice little addon and a good starting point to inspect and explore.

As this addon is currently used and referenced in FAQ block type example in "Mastering Plone 6 Development" I thought it would be a good idea to at least keep it working.

I also submitted a PR with the same fixes to make the code example work within the training as well.
plone/training#626

@ksuess ksuess closed this as completed in #3 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants