Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ block type code example #626

Merged
merged 3 commits into from
Jul 16, 2022
Merged

Conversation

mliebischer
Copy link
Contributor

The example code for the faq block type was outdated. Those are the same fixes as in rohberg/volto-accordion-block#1

The example code for the faq block type was outdated. Those are the same fixes as in rohberg/volto-accordion-block#1
@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for plone-training ready!

Name Link
🔨 Latest commit b85aac2
🔍 Latest deploy log https://app.netlify.com/sites/plone-training/deploys/62d2933f030dc4000964a183
😎 Deploy Preview https://deploy-preview-626--plone-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor change.

Someone familiar with this training's technical details should review before merging.

@stevepiercy stevepiercy added this to the Plone 6.0 milestone Jul 8, 2022
@stevepiercy
Copy link
Contributor

I just noticed that the two test failures are from redirects in links.

I could either fix them in a separate PR and you can merge main into your branch, or you can fix them as part of this PR. Please let me know. Thank you!

Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for caring!
With the figure brought back, I will approve.

Comment on lines 584 to 587

```{figure} _static/volto_addon_accordion_add.png
:alt: "@rohberg/volto-accordion-block"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the figure.

```{figure} _static/volto_addon_accordion_add.png
:alt: "@rohberg/volto-accordion-block"
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, the figure was accidentally deleted.

@ksuess
Copy link
Member

ksuess commented Jul 9, 2022

I just noticed that the two test failures are from redirects in links.

* https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3035

* https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3082

I could either fix them in a separate PR and you can merge main into your branch, or you can fix them as part of this PR. Please let me know. Thank you!

It was just a tempoararily broken link: https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3086
With a re-run of the test it's fine now.

Just ping us on Discord channel "documentation" https://discord.com/channels/786421998426521600/862642144401031188 if an unrelated test failure happens.

A re-run of tests can be done by heading over to tab "actions" and restart failed tests like the linkcheck.
image

@stevepiercy
Copy link
Contributor

Oh, that's right. We don't run linkcheckbroken with it erroring it out on either broken or redirect, like we do in plone/documentation. Maybe we should?

In any case, those two redirect links must be fixed, either in this PR or another.

@stevepiercy stevepiercy mentioned this pull request Jul 10, 2022
@stevepiercy
Copy link
Contributor

In any case, those two redirect links must be fixed, either in this PR or another.

Done in #627.

@mliebischer once you restore the figure, we can merge. Thank you!

@ksuess ksuess merged commit 48bf5cd into main Jul 16, 2022
@ksuess ksuess deleted the mliebischer-fix-faq-block-example branch July 16, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants