-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FAQ block type code example #626
Conversation
The example code for the faq block type was outdated. Those are the same fixes as in rohberg/volto-accordion-block#1
✅ Deploy Preview for plone-training ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor change.
Someone familiar with this training's technical details should review before merging.
I just noticed that the two test failures are from redirects in links.
I could either fix them in a separate PR and you can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for caring!
With the figure brought back, I will approve.
|
||
```{figure} _static/volto_addon_accordion_add.png | ||
:alt: "@rohberg/volto-accordion-block" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the figure.
```{figure} _static/volto_addon_accordion_add.png
:alt: "@rohberg/volto-accordion-block"
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, the figure was accidentally deleted.
It was just a tempoararily broken link: https://github.com/plone/training/runs/7249210720?check_suite_focus=true#step:5:3086 Just ping us on Discord channel "documentation" https://discord.com/channels/786421998426521600/862642144401031188 if an unrelated test failure happens. A re-run of tests can be done by heading over to tab "actions" and restart failed tests like the linkcheck. |
Oh, that's right. We don't run In any case, those two redirect links must be fixed, either in this PR or another. |
Done in #627. @mliebischer once you restore the figure, we can merge. Thank you! |
The example code for the faq block type was outdated. Those are the same fixes as in rohberg/volto-accordion-block#1