fix : efficient job card overlap finding algorithm #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efficiency in execution speed This algorithm will run faster as its inner loop will run number of key times.key will start from 1 as the outer loop progressed it can run more keys. Here is an extreme example: let say time_logs have 5 job cards All are overlapping so 1st outer iteration run only single time inner loop 2nd outer iteration will run 2 times inner loop as previous both jc are overlapping like wise 3rd outer iteration will run 3 times so total iteration = 1+2+3+4 = 10 times. in previous it was running 25 times as 5 in list. this algorithm will run for 10 times or lower for list having 5 job cards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Efficiency in execution speed
This algorithm will run faster as its inner loop will run number of key times.key will start from 1 as the outer loop progressed it can run more keys. Here is an extreme example:
let say time_logs have 5 job cards
All are overlapping
so 1st outer iteration run only single time inner loop 2nd outer iteration will run 2 times inner loop as previous both jc are overlapping like wise 3rd outer iteration will run 3 times
so total iteration = 1+2+3+4 = 10 times.
in previous it was running 25 times as 5 in list.
this algorithm will run for 10 times or lower for list having 5 job cards.