Don't bail for MaterialColors and Attributes parse failures #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #293, we changed the rbx_binary deserializer to bail completely when it fails to read attributes. This turns out to be a pretty bad idea, because it means when Roblox changes the attributes format, any files containing the new version cannot be parsed at all.
This PR allows MaterialColors and Attributes to be parsed as BinaryStrings when they cannot be parsed into their specialized types in both rbx_binary and rbx_xml, and changes the corresponding rbx_dom_lua custom property codecs to fail gracefully under these conditions. I'm thinking we might want to do this for Tags too, but I'm not sure... let me know what you think!