Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#100] Wayfinding Spaces and Places Floor plan end points #101

Conversation

clint156
Copy link
Collaborator

Description

Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Implement the floorplans and building search end points for the spaces and places endpoints as part of the wayfinding data exposed by the apis.

**Resolves #100 **

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • [ x] Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • [x ] New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • [ x] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • [x ] I have updated the CHANGELOG.
  • [x ] I have read the Contributor Guidelines.
  • [x ] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly in hard-to-understand areas.
  • [x ] My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • [ x] My changes generate no new warnings.
  • [x ] New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@clint156 clint156 linked an issue Jun 26, 2024 that may be closed by this pull request
@clint156 clint156 requested a review from petyos June 26, 2024 14:37
@clint156
Copy link
Collaborator Author

Swagger documentation still needs to be completed but I need to get the changes to Dev for Aidan quickly and it's taking me a while to work through the documentation I need to. I will open a new issue for documentation to address that.

@clint156
Copy link
Collaborator Author

for sake of time, skipping review.

@clint156 clint156 closed this Jun 27, 2024
@clint156 clint156 reopened this Jun 27, 2024
@clint156 clint156 merged commit 3149553 into develop Jun 27, 2024
4 checks passed
@clint156 clint156 deleted the 100-bug-building-number-field-is-empty-when-hitting-wayfinding-endpoints branch June 27, 2024 18:58
clint156 added a commit that referenced this pull request Jun 28, 2024
* [#100] Wayfinding Spaces and Places Floor plan end points (#101)

* added building number to wayfinding, floor plan structs

* set up adapter to pull floor plan data

* Add Floors and Features to buildings

* building features is collection of objects

* caching full building list

* add search endpoing and supporting data structs

* updated documentation and fixed lint errors

* Update changelog

* update .secrets.baseline

* Release v2.10.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] WayFinding Spaces and Places Floor plan end points
1 participant