Fixed SDK-426 scrubbing for namedtuples #474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change fixes an issue where named tuple fields included in
scrub_fields
were not being scrubbed/redacted before the namedtuple was serialized.This was caused by the
_serialize_frame_data()
method runningScrubRedactTransform()
without checking thescrub_fields
values before serializng the namedtuple. As a result by the time we came to scrub the namedtuple with thescrub_fields
values had been serialized to a string.This PR creates an instance of
ScrubRedactTransform
duringinit()
that is passed thescrub_fields
and used during both_serialize_frame_data()
and_transform()
.While makeing that change I noticed that
ScrubRedactTransform
can further do the work ofScrubTransform
if it is passed the same arguments during initialization. Because of that I removedScrubTransform
from the list of transforms sinceScrubRedactTransform
will do both now. This futher reduces the total number of traversals and transforms we need to do of the data, making it more efficient.Type of change
Related issues
Checklists
Development
Code review