Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add README and import script #261

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 13, 2023

Overview

Resolves #193

This removes the building-with-rollkit page and uses the README from rollkit/rollkit using an importReadme.mjs script.

This is so that we can import with a script similarly to the way that this script pulls in Blobstream (fka QGB) docs in.

This PR is to be updated and merged after this 1247 on rollkit

Preview of page in this PR

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from nashqueue October 13, 2023 18:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-19 16:05 UTC

@jcstein jcstein changed the title chore: update building-with-rollkit page chore: update building-with-rollkit page and import workflow Oct 13, 2023
@MSevey
Copy link
Contributor

MSevey commented Oct 13, 2023

Does this render updates automatically?

If so, do we have any concerns with it targeting main vs a release?

If it targets a release, we could look into setting a trigger to auto update this like the other versions in the docs.

@jcstein jcstein removed the request for review from nashqueue October 13, 2023 19:56
@jcstein
Copy link
Member Author

jcstein commented Oct 13, 2023

the script can currently be ran manually. the current idea would be to run this after a release of rollkit, and make a PR with the edited file. just run yarn import-readme, then push, & make PR

however, i think targeting a release, turning this into a github action instead of just a script, and implementing latest tags workflow in vitepress is better in the long run

@jcstein jcstein marked this pull request as ready for review October 17, 2023 14:33
@jcstein jcstein self-assigned this Oct 18, 2023
@jcstein jcstein requested a review from nashqueue October 18, 2023 14:55
@jcstein
Copy link
Member Author

jcstein commented Oct 18, 2023

are you alright with merging this and in a following PR completing:

opened #263 to track these

@jcstein
Copy link
Member Author

jcstein commented Oct 18, 2023

@jcstein jcstein changed the title chore: update building-with-rollkit page and import workflow chore: add README and import workflow Oct 18, 2023
@jcstein jcstein changed the title chore: add README and import workflow chore: add README and import script Oct 18, 2023
Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nashqueue nashqueue merged commit a405423 into main Oct 19, 2023
2 checks passed
@nashqueue nashqueue deleted the jcs/bump-building-w-rolkit-vers branch October 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import README to docs for "building with rollkit" page
3 participants