-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gas price docs #328
feat: gas price docs #328
Conversation
WalkthroughThis update brings a new file explaining how to configure gas prices for a rollup. It details setting fixed gas prices and enabling manual adjustments to efficiently manage network congestion. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Resolves #300 When ready for review, will work into menu with you |
4d001f2
to
bcddc86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 4
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tutorials/gas-price.md (1 hunks)
Additional comments: 2
tutorials/gas-price.md (2)
- 3-4: Consider adding a brief explanation of what "gas price" means for readers who might be new to the concept. This can help make the tutorial more accessible to a broader audience.
- 6-10: The flag
--rollkit.da_gas_price
is mentioned as a way to manually configure the gas price. It might be helpful to clarify whether this flag is specific to a certain command (gmd start
) or can be used with other commands as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- tutorials/gas-price.md (1 hunks)
Additional comments: 1
tutorials/gas-price.md (1)
- 1-32: The tutorial on configuring gas prices is clear, well-structured, and adheres to the objectives outlined in the PR. It provides valuable information on setting fixed gas prices and adjusting for network congestion, which will enhance the project's documentation.
The spelling "mistakes" identified by the static analysis tool are related to technical terms and commands, and thus, are not actual errors. This document is ready for integration into the project's documentation menu.
i’ll review this tomorrow. i think it just needs added to the sidebar in configOn Mar 18, 2024, at 11:01 AM, Ganesha Upadhyaya ***@***.***> wrote:
@gupadhyaya requested your review on: #328 feat: gas price docs.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Overview
This PR adds a tutorial describing the gas price flags.
Checklist
Summary by CodeRabbit