-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update gm tutorial to use kurtosis #414
Conversation
Note Reviews pausedUse the following commands to manage reviews:
WalkthroughThe tutorial for launching and managing the GM rollup has been updated to incorporate the use of Kurtosis. This includes instructions on managing services, launching the rollup, and interacting with it via Docker containers. The command for installation and verification steps have been revised to reflect the new approach using Kurtosis. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Kurtosis
participant Docker
participant Rollkit
User ->> Kurtosis: Run installation command
Kurtosis ->> Docker: Set up GM rollup environment
Docker ->> Rollkit: Launch GM rollup containers
User ->> Docker: Check running containers
Docker ->> User: Display list of containers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tutorials/gm-world.md (2 hunks)
Additional context used
LanguageTool
tutorials/gm-world.md
[uncategorized] ~32-~32: Possible missing comma found.
Context: ...es} As we moved into more advanced use cases we use [kurtosis](https://docs.kurtosis...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~34-~34: Possible missing comma found.
Context: ...ps://docs.kurtosis.com/install). Once installed you can verify the installation by runn...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~46-~46: There is an agreement error between ‘have’ and ‘kurtosis’. Insert ‘a(n)’ or change the noun to plural.
Context: ...ollup {#start-your-rollup} Now that we have kurtosis, we can launch our GM rollup along with...(PRP_VB_NN)
Markdownlint
tutorials/gm-world.md
32-32: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
Additional comments not posted (3)
tutorials/gm-world.md (3)
49-49
: LGTM!The command to launch the GM rollup using kurtosis is correct.
55-112
: LGTM!The updated output and docker commands correctly reflect the new process using kurtosis.
153-157
: LGTM!The command to enter the docker container is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Minor typo.
@coderabbitai resolve |
@coderabbitai ignore |
Actions performedComments resolved. |
@coderabbitai ignore Actions performedReviews paused. |
Overview
Blocked on rollkit/gm#110
Now that the GM rollup and frontend can be run all at once with the kurtosis package we can merge the two tutorials.
Summary by CodeRabbit