Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct method names from BankKeeper module #415

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

gupadhyaya
Copy link
Member

@gupadhyaya gupadhyaya commented Jul 7, 2024

Fixes #348

Summary by CodeRabbit

  • New Features

    • Improved validation for Wordle guesses.
    • Enhanced daily management of Wordle submissions.
    • Updated reward processing for correct Wordle guesses.
  • Refactor

    • Reordered import statements and adjusted function parameters for better code clarity and maintainability.

Copy link
Contributor

coderabbitai bot commented Jul 7, 2024

Walkthrough

The changes streamline the Wordle tutorial and resolve issues with the BankKeeper dispatch. The modifications include reordering imports, adjusting function parameters, and updating method calls to handle Wordle guesses and rewards. These improvements ensure valid guesses, manage daily submissions, and accurately process rewards for correct answers.

Changes

Files/Paths Change Summaries
tutorials/wordle.md Updated import order, adjusted function parameters, modified method calls for guess submission and reward handling.
keeper/*.go Adjusted function signatures for SubmitWordle, SubmitGuess, and IsLetter.
x/wordle/types/expected_keepers.go Updated BankKeeper interface methods to SendCoinsFromModuleToAccount and SendCoinsFromAccountToModule.

Sequence Diagram(s)

N/A

Assessment against linked issues

Objective Addressed Explanation
Resolving BankKeeper dispatch issues (#348) Changes are implemented, but without testing the fix, it's unclear if the issue is fully resolved.

Poem

In Wordle's world, we tweak and mend,
To make your guesses pay in end,
Rewards are set, submissions fair,
With code so fine, bugs rare, cares bare.
Hop along, the game’s now grand,
A puzzle fixed by rabbit's hand! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RollkitBot RollkitBot requested review from tuxcanfly and tzdybal July 7, 2024 17:21
@gupadhyaya gupadhyaya requested review from Manav-Aggarwal and removed request for tuxcanfly and tzdybal July 7, 2024 17:21
Copy link
Contributor

github-actions bot commented Jul 7, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://rollkit.github.io/docs-preview/./pr-415/
on branch main at 2024-07-07 17:26 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7bbce6a and 7a32441.

Files selected for processing (1)
  • tutorials/wordle.md (3 hunks)
Additional context used
Markdownlint
tutorials/wordle.md

312-312: Column: 1
Hard tabs

(MD010, no-hard-tabs)


313-313: Column: 1
Hard tabs

(MD010, no-hard-tabs)


314-314: Column: 1
Hard tabs

(MD010, no-hard-tabs)


315-315: Column: 1
Hard tabs

(MD010, no-hard-tabs)


316-316: Column: 1
Hard tabs

(MD010, no-hard-tabs)


317-317: Column: 1
Hard tabs

(MD010, no-hard-tabs)


319-319: Column: 1
Hard tabs

(MD010, no-hard-tabs)


320-320: Column: 1
Hard tabs

(MD010, no-hard-tabs)


321-321: Column: 1
Hard tabs

(MD010, no-hard-tabs)


325-325: Column: 1
Hard tabs

(MD010, no-hard-tabs)


326-326: Column: 1
Hard tabs

(MD010, no-hard-tabs)


327-327: Column: 1
Hard tabs

(MD010, no-hard-tabs)


328-328: Column: 1
Hard tabs

(MD010, no-hard-tabs)


329-329: Column: 1
Hard tabs

(MD010, no-hard-tabs)


330-330: Column: 1
Hard tabs

(MD010, no-hard-tabs)


331-331: Column: 1
Hard tabs

(MD010, no-hard-tabs)


332-332: Column: 1
Hard tabs

(MD010, no-hard-tabs)


333-333: Column: 1
Hard tabs

(MD010, no-hard-tabs)


335-335: Column: 1
Hard tabs

(MD010, no-hard-tabs)


336-336: Column: 1
Hard tabs

(MD010, no-hard-tabs)


337-337: Column: 1
Hard tabs

(MD010, no-hard-tabs)


338-338: Column: 1
Hard tabs

(MD010, no-hard-tabs)


339-339: Column: 1
Hard tabs

(MD010, no-hard-tabs)


340-340: Column: 1
Hard tabs

(MD010, no-hard-tabs)


341-341: Column: 1
Hard tabs

(MD010, no-hard-tabs)


342-342: Column: 1
Hard tabs

(MD010, no-hard-tabs)


344-344: Column: 1
Hard tabs

(MD010, no-hard-tabs)


345-345: Column: 1
Hard tabs

(MD010, no-hard-tabs)


346-346: Column: 1
Hard tabs

(MD010, no-hard-tabs)


347-347: Column: 1
Hard tabs

(MD010, no-hard-tabs)


348-348: Column: 1
Hard tabs

(MD010, no-hard-tabs)


350-350: Column: 1
Hard tabs

(MD010, no-hard-tabs)


351-351: Column: 1
Hard tabs

(MD010, no-hard-tabs)


352-352: Column: 1
Hard tabs

(MD010, no-hard-tabs)


353-353: Column: 1
Hard tabs

(MD010, no-hard-tabs)


354-354: Column: 1
Hard tabs

(MD010, no-hard-tabs)


355-355: Column: 1
Hard tabs

(MD010, no-hard-tabs)


356-356: Column: 1
Hard tabs

(MD010, no-hard-tabs)


357-357: Column: 1
Hard tabs

(MD010, no-hard-tabs)


358-358: Column: 1
Hard tabs

(MD010, no-hard-tabs)


359-359: Column: 1
Hard tabs

(MD010, no-hard-tabs)


360-360: Column: 1
Hard tabs

(MD010, no-hard-tabs)


361-361: Column: 1
Hard tabs

(MD010, no-hard-tabs)


362-362: Column: 1
Hard tabs

(MD010, no-hard-tabs)


363-363: Column: 1
Hard tabs

(MD010, no-hard-tabs)


364-364: Column: 1
Hard tabs

(MD010, no-hard-tabs)


365-365: Column: 1
Hard tabs

(MD010, no-hard-tabs)


369-369: Column: 1
Hard tabs

(MD010, no-hard-tabs)


370-370: Column: 1
Hard tabs

(MD010, no-hard-tabs)


371-371: Column: 1
Hard tabs

(MD010, no-hard-tabs)


372-372: Column: 1
Hard tabs

(MD010, no-hard-tabs)


373-373: Column: 1
Hard tabs

(MD010, no-hard-tabs)


374-374: Column: 1
Hard tabs

(MD010, no-hard-tabs)


406-406: Column: 1
Hard tabs

(MD010, no-hard-tabs)


407-407: Column: 1
Hard tabs

(MD010, no-hard-tabs)


408-408: Column: 1
Hard tabs

(MD010, no-hard-tabs)


409-409: Column: 1
Hard tabs

(MD010, no-hard-tabs)


410-410: Column: 1
Hard tabs

(MD010, no-hard-tabs)


411-411: Column: 1
Hard tabs

(MD010, no-hard-tabs)


413-413: Column: 1
Hard tabs

(MD010, no-hard-tabs)


414-414: Column: 1
Hard tabs

(MD010, no-hard-tabs)


415-415: Column: 1
Hard tabs

(MD010, no-hard-tabs)


419-419: Column: 1
Hard tabs

(MD010, no-hard-tabs)


420-420: Column: 1
Hard tabs

(MD010, no-hard-tabs)


421-421: Column: 1
Hard tabs

(MD010, no-hard-tabs)


422-422: Column: 1
Hard tabs

(MD010, no-hard-tabs)


423-423: Column: 1
Hard tabs

(MD010, no-hard-tabs)


425-425: Column: 1
Hard tabs

(MD010, no-hard-tabs)


426-426: Column: 1
Hard tabs

(MD010, no-hard-tabs)


427-427: Column: 1
Hard tabs

(MD010, no-hard-tabs)


428-428: Column: 1
Hard tabs

(MD010, no-hard-tabs)


430-430: Column: 1
Hard tabs

(MD010, no-hard-tabs)


431-431: Column: 1
Hard tabs

(MD010, no-hard-tabs)


432-432: Column: 1
Hard tabs

(MD010, no-hard-tabs)


433-433: Column: 1
Hard tabs

(MD010, no-hard-tabs)


434-434: Column: 1
Hard tabs

(MD010, no-hard-tabs)


435-435: Column: 1
Hard tabs

(MD010, no-hard-tabs)


436-436: Column: 1
Hard tabs

(MD010, no-hard-tabs)


437-437: Column: 1
Hard tabs

(MD010, no-hard-tabs)


438-438: Column: 1
Hard tabs

(MD010, no-hard-tabs)


440-440: Column: 1
Hard tabs

(MD010, no-hard-tabs)


441-441: Column: 1
Hard tabs

(MD010, no-hard-tabs)


442-442: Column: 1
Hard tabs

(MD010, no-hard-tabs)


443-443: Column: 1
Hard tabs

(MD010, no-hard-tabs)


444-444: Column: 1
Hard tabs

(MD010, no-hard-tabs)


445-445: Column: 1
Hard tabs

(MD010, no-hard-tabs)


446-446: Column: 1
Hard tabs

(MD010, no-hard-tabs)


447-447: Column: 1
Hard tabs

(MD010, no-hard-tabs)


449-449: Column: 1
Hard tabs

(MD010, no-hard-tabs)


450-450: Column: 1
Hard tabs

(MD010, no-hard-tabs)


451-451: Column: 1
Hard tabs

(MD010, no-hard-tabs)


452-452: Column: 1
Hard tabs

(MD010, no-hard-tabs)


453-453: Column: 1
Hard tabs

(MD010, no-hard-tabs)


454-454: Column: 1
Hard tabs

(MD010, no-hard-tabs)


455-455: Column: 1
Hard tabs

(MD010, no-hard-tabs)


456-456: Column: 1
Hard tabs

(MD010, no-hard-tabs)


457-457: Column: 1
Hard tabs

(MD010, no-hard-tabs)


458-458: Column: 1
Hard tabs

(MD010, no-hard-tabs)


459-459: Column: 1
Hard tabs

(MD010, no-hard-tabs)


460-460: Column: 1
Hard tabs

(MD010, no-hard-tabs)


461-461: Column: 1
Hard tabs

(MD010, no-hard-tabs)


462-462: Column: 1
Hard tabs

(MD010, no-hard-tabs)


463-463: Column: 1
Hard tabs

(MD010, no-hard-tabs)


464-464: Column: 1
Hard tabs

(MD010, no-hard-tabs)


465-465: Column: 1
Hard tabs

(MD010, no-hard-tabs)


466-466: Column: 1
Hard tabs

(MD010, no-hard-tabs)


467-467: Column: 1
Hard tabs

(MD010, no-hard-tabs)


468-468: Column: 1
Hard tabs

(MD010, no-hard-tabs)


469-469: Column: 1
Hard tabs

(MD010, no-hard-tabs)


470-470: Column: 1
Hard tabs

(MD010, no-hard-tabs)


471-471: Column: 1
Hard tabs

(MD010, no-hard-tabs)


472-472: Column: 1
Hard tabs

(MD010, no-hard-tabs)


473-473: Column: 1
Hard tabs

(MD010, no-hard-tabs)


474-474: Column: 1
Hard tabs

(MD010, no-hard-tabs)


475-475: Column: 1
Hard tabs

(MD010, no-hard-tabs)


476-476: Column: 1
Hard tabs

(MD010, no-hard-tabs)


477-477: Column: 1
Hard tabs

(MD010, no-hard-tabs)


478-478: Column: 1
Hard tabs

(MD010, no-hard-tabs)


479-479: Column: 1
Hard tabs

(MD010, no-hard-tabs)


480-480: Column: 1
Hard tabs

(MD010, no-hard-tabs)


481-481: Column: 1
Hard tabs

(MD010, no-hard-tabs)


482-482: Column: 1
Hard tabs

(MD010, no-hard-tabs)


483-483: Column: 1
Hard tabs

(MD010, no-hard-tabs)


484-484: Column: 1
Hard tabs

(MD010, no-hard-tabs)


485-485: Column: 1
Hard tabs

(MD010, no-hard-tabs)


486-486: Column: 1
Hard tabs

(MD010, no-hard-tabs)


487-487: Column: 1
Hard tabs

(MD010, no-hard-tabs)


488-488: Column: 1
Hard tabs

(MD010, no-hard-tabs)


489-489: Column: 1
Hard tabs

(MD010, no-hard-tabs)


490-490: Column: 1
Hard tabs

(MD010, no-hard-tabs)


491-491: Column: 1
Hard tabs

(MD010, no-hard-tabs)


537-537: Column: 1
Hard tabs

(MD010, no-hard-tabs)

Additional comments not posted (6)
tutorials/wordle.md (6)

361-364: LGTM! The method call and error handling are correct.

The method SendCoinsFromAccountToModule is used correctly and the error handling is appropriate.

Tools
Markdownlint

361-361: Column: 1
Hard tabs

(MD010, no-hard-tabs)


362-362: Column: 1
Hard tabs

(MD010, no-hard-tabs)


363-363: Column: 1
Hard tabs

(MD010, no-hard-tabs)


364-364: Column: 1
Hard tabs

(MD010, no-hard-tabs)


486-489: LGTM! The method call and error handling are correct.

The method SendCoinsFromModuleToAccount is used correctly and the error handling is appropriate.

Tools
Markdownlint

486-486: Column: 1
Hard tabs

(MD010, no-hard-tabs)


487-487: Column: 1
Hard tabs

(MD010, no-hard-tabs)


488-488: Column: 1
Hard tabs

(MD010, no-hard-tabs)


489-489: Column: 1
Hard tabs

(MD010, no-hard-tabs)


536-537: LGTM! The method declarations in the BankKeeper interface are correct.

The methods SendCoinsFromModuleToAccount and SendCoinsFromAccountToModule are correctly declared in the BankKeeper interface.

Tools
Markdownlint

537-537: Column: 1
Hard tabs

(MD010, no-hard-tabs)


361-364: Verify the correctness of the method call SendCoinsFromAccountToModule.

Ensure that the method SendCoinsFromAccountToModule is correctly implemented in the BankKeeper module and that it handles errors properly.

Tools
Markdownlint

361-361: Column: 1
Hard tabs

(MD010, no-hard-tabs)


362-362: Column: 1
Hard tabs

(MD010, no-hard-tabs)


363-363: Column: 1
Hard tabs

(MD010, no-hard-tabs)


364-364: Column: 1
Hard tabs

(MD010, no-hard-tabs)


486-489: Verify the correctness of the method call SendCoinsFromModuleToAccount.

Ensure that the method SendCoinsFromModuleToAccount is correctly implemented in the BankKeeper module and that it handles errors properly.

Tools
Markdownlint

486-486: Column: 1
Hard tabs

(MD010, no-hard-tabs)


487-487: Column: 1
Hard tabs

(MD010, no-hard-tabs)


488-488: Column: 1
Hard tabs

(MD010, no-hard-tabs)


489-489: Column: 1
Hard tabs

(MD010, no-hard-tabs)


536-537: Verify the correctness of the method declarations in the BankKeeper interface.

Ensure that the methods SendCoinsFromModuleToAccount and SendCoinsFromAccountToModule are correctly declared in the BankKeeper interface.

Tools
Markdownlint

537-537: Column: 1
Hard tabs

(MD010, no-hard-tabs)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7a32441 and 64dc71f.

Files selected for processing (1)
  • tutorials/wordle.md (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • tutorials/wordle.md

Copy link
Contributor

@yarikbratashchuk yarikbratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@gupadhyaya gupadhyaya merged commit 9b4d506 into main Jul 9, 2024
4 checks passed
@gupadhyaya gupadhyaya deleted the fix_wordle branch July 9, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing bankKeeper dispatch in Wordle tutorial
2 participants