Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: replace celestia with celestia-da #75

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Nov 16, 2023

Overview

Fixes #74

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features

    • Introduced gRPC service on port 26650 for the Data Availability Service.
    • Updated Docker base image to enhance application stability and performance.
  • Documentation

    • Updated README.md with new port mappings and environment variable usage instructions.
  • Refactor

    • Modified entrypoint script to initialize and start the celestia-da bridge with new parameters for improved service integration.
  • Chores

    • Adjusted Dockerfile to expose additional port and include necessary package installations.

Copy link

coderabbitai bot commented Nov 16, 2023

Walkthrough

The recent updates integrate celestia-da, a gRPC Data Availability service, into the local Celestia devnet Docker image. This allows for a more streamlined setup for projects that require interaction with Celestia's gRPC interface, as they no longer need to run an additional process for this service. The changes include updating the base Docker image, exposing a new port for gRPC, and modifying the entrypoint script to initialize and start the celestia-da service with the necessary parameters.

Changes

File(s) Change Summary
Dockerfile Updated base image to ghcr.io/rollkit/celestia-da:v0.12.1-rc0, added openssl installation, and exposed port 26650.
README.md Updated port mappings and documentation to include gRPC port 26650 and CELESTIA_NAMESPACE environment variable.
entrypoint.sh Replaced celestia with celestia-da commands, added --da.grpc.namespace and --da.grpc.listen parameters, and set CELESTIA_NAMESPACE with a generated value if unset.

Assessment against linked issues

Objective Addressed Explanation
Support celestia-da in the Docker image for local devnet integrations (#74) The Dockerfile and entrypoint script have been updated to include and configure celestia-da.

Poem

In the Docker's cozy burrow, a new service does appear,
celestia-da now included, for all the devs to cheer. 🎉
No more extra processes, just one image to run,
With gRPC on port 26650, integration's now more fun.
A rabbit's work is never done, with code that hops and leaps,
Now settle down, dear services, and rest your weary beeps. 💤


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between dd90c11 and 5367d8e.
Files selected for processing (3)
  • Dockerfile (2 hunks)
  • README.md (4 hunks)
  • entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • README.md
Additional comments: 2
Dockerfile (2)
  • 1-3: The base image has been updated to use opcelestia/celestia-da:v0.12.0. Ensure that this image is available in the registry and that all necessary dependencies for the application are satisfied by this new image.

  • 20-20: The newly exposed port 26650 is for gRPC services. Verify that the application's security considerations have been updated to account for this new port being exposed, and ensure that any necessary firewall rules or security group settings are configured to allow traffic as needed.

entrypoint.sh Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@tuxcanfly tuxcanfly marked this pull request as ready for review November 24, 2023 15:18
@gupadhyaya
Copy link
Member

@tuxcanfly can you update the docker file?

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 98cb31e and 9969656.
Files selected for processing (3)
  • Dockerfile (2 hunks)
  • README.md (4 hunks)
  • entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (2)
  • Dockerfile
  • README.md
Additional comments: 1
entrypoint.sh (1)
  • 73-85:

The changes to the entrypoint script correctly implement the switch from celestia to celestia-da and add the necessary gRPC flags as described in the summary. However, ensure that the CELESTIA_NODE_AUTH_TOKEN is securely handled in production environments to prevent unauthorized access.

@tuxcanfly
Copy link
Contributor Author

OK, updated to use celestia-da v0.12.1-rc0. This version bundles celestia-node dd3b8e1411de.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9969656 and 2c239dd.
Files selected for processing (1)
  • entrypoint.sh (1 hunks)

entrypoint.sh Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2c239dd and 4855936.
Files selected for processing (1)
  • entrypoint.sh (1 hunks)

entrypoint.sh Outdated Show resolved Hide resolved
Manav-Aggarwal
Manav-Aggarwal previously approved these changes Nov 24, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4855936 and e57b7dd.
Files selected for processing (2)
  • Dockerfile (2 hunks)
  • entrypoint.sh (1 hunks)
Additional comments: 5
Dockerfile (3)
  • 1-3:
    The base image has been updated to ghcr.io/rollkit/celestia-da:v0.12.1-rc0. Ensure that this new image is compatible with the existing application and that all necessary dependencies are met.

  • 11-11:
    The addition of the openssl package is noted. Verify that this package is indeed required for the new Celestia Data Availability service and that it does not introduce any security vulnerabilities.

  • 21-21:
    The EXPOSE instruction has been updated to include port 26650 for the gRPC Data Availability Service. Ensure that this port is correctly configured in any deployment environments and that it does not conflict with any existing services.

entrypoint.sh (2)
  • 76-78:
    Ensure that the CELESTIA_NAMESPACE environment variable is documented and that users are aware of how it is set if not provided.

  • 81-87:
    The changes correctly reflect the shift to the Celestia Data Availability service and the addition of gRPC parameters as described in the summary.

@tuxcanfly
Copy link
Contributor Author

Namespace can be configured from the environment using CELESTIA_NAMESPACE variable.

Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@nashqueue nashqueue merged commit 47023b9 into main Nov 25, 2023
7 checks passed
@nashqueue nashqueue deleted the tux/celestia-da branch November 25, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: support celestia-da
4 participants