-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: replace celestia with celestia-da #75
Conversation
WalkthroughThe recent updates integrate Changes
Assessment against linked issues
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (3)
- Dockerfile (2 hunks)
- README.md (4 hunks)
- entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- README.md
Additional comments: 2
Dockerfile (2)
1-3: The base image has been updated to use
opcelestia/celestia-da:v0.12.0
. Ensure that this image is available in the registry and that all necessary dependencies for the application are satisfied by this new image.20-20: The newly exposed port
26650
is for gRPC services. Verify that the application's security considerations have been updated to account for this new port being exposed, and ensure that any necessary firewall rules or security group settings are configured to allow traffic as needed.
@tuxcanfly can you update the docker file? |
5367d8e
to
9969656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- Dockerfile (2 hunks)
- README.md (4 hunks)
- entrypoint.sh (1 hunks)
Files skipped from review due to trivial changes (2)
- Dockerfile
- README.md
Additional comments: 1
entrypoint.sh (1)
- 73-85:
The changes to the entrypoint script correctly implement the switch from
celestia
tocelestia-da
and add the necessary gRPC flags as described in the summary. However, ensure that theCELESTIA_NODE_AUTH_TOKEN
is securely handled in production environments to prevent unauthorized access.
OK, updated to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- Dockerfile (2 hunks)
- entrypoint.sh (1 hunks)
Additional comments: 5
Dockerfile (3)
1-3:
The base image has been updated toghcr.io/rollkit/celestia-da:v0.12.1-rc0
. Ensure that this new image is compatible with the existing application and that all necessary dependencies are met.11-11:
The addition of theopenssl
package is noted. Verify that this package is indeed required for the new Celestia Data Availability service and that it does not introduce any security vulnerabilities.21-21:
TheEXPOSE
instruction has been updated to include port26650
for the gRPC Data Availability Service. Ensure that this port is correctly configured in any deployment environments and that it does not conflict with any existing services.entrypoint.sh (2)
76-78:
Ensure that theCELESTIA_NAMESPACE
environment variable is documented and that users are aware of how it is set if not provided.81-87:
The changes correctly reflect the shift to the Celestia Data Availability service and the addition of gRPC parameters as described in the summary.
Namespace can be configured from the environment using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Overview
Fixes #74
Checklist
Summary by CodeRabbit
New Features
Documentation
Refactor
celestia-da
bridge with new parameters for improved service integration.Chores