Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default param #20

Closed
wants to merge 8 commits into from
Closed

Conversation

MarnuLombard
Copy link

@MarnuLombard MarnuLombard commented Apr 27, 2021

Thinking is that the parent can pass a selected <option> upon initialisation.

  • c250fe0 Add support for passing a default param
    • The item that will be selected upon initialisation of the component
    • Allows for parent to define the selected upon load
  • 00aa85b Document default in the README
  • 404efb8 Compiled JS
    • Ran npm run build
  • 80c28ab Documented default param in CHANGELOG
  • ec41468 Handle falsey values passed in as default param
    • eg, null, undefined, etc
    • Extract selecting none into a method and remove duplication

- The item that will be selected upon initialisation of the component
- Allows for parent to define the selected upon load
- Ran `npm run build`
@MarnuLombard
Copy link
Author

MarnuLombard commented Apr 27, 2021

Other users have requested this, see issue #19 and issue #12

- I initially believed it was required as `default` was reserved
- eg, `null`, `undefined`, etc
- Extract selecting none into a method and remove duplication
- Ran `npm run build`
@mtfuji25
Copy link

mtfuji25 commented Jul 7, 2021

Is :default prop working properly, @MarnuLombard?
I tried your commits but it does not work.

@MarnuLombard
Copy link
Author

Is :default prop working properly, @MarnuLombard?
I tried your commits but it does not work.

It was working fine for me by the time I opened this PR. But in all honesty I abandoned this lib in my project due to problematic dependancy definitions and lack of support.
I moved over to vue-simple-suggest.

@MarnuLombard
Copy link
Author

Closing PR due to lack of maintainer response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants