Implement simpleComparison() and create load tests for issue #119 and #174 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hannnnnnn404
changed the title
Hannnnnnn404
changed the title
romankh3
reviewed
Apr 21, 2022
| @Test | ||
| @DisplayName("compare load differences between {@link simpleComparison} method and {@link compareImage} method") | ||
| public void loadTest2(){ | ||
| //load images to be compared: |
There was a problem hiding this comment.
Please, follow general way for creating tests with BDD blocks:
//given
//when
//then
There was a problem hiding this comment.
Do you mean that I should code tests following the BDD style? I‘m trying to modified my tests.
There was a problem hiding this comment.
Please, follow general way for creating tests with BDD blocks: //given //when //then
Do you mean that I should code tests following the BDD style? And my logic of load tests is right.
|
thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
simpleComparison(), which makes it faster thancompareImages().simpleComparison()method is faster.Description
simpleComparison(), which makes it faster to compare images without drawing rectangles.isFirstDifference()method to judge the first different pixel of two images.simpleComparison()andcompareImages().Related Issue
Motivation and Context
The change is aim to users who don't want to know what differences of compare images. Some users only need to know that if two images are different or not. This
simpleComparisonpattern can makes it faster for users to get result quickly.How Has This Been Tested
simpleComparison()feature to make sure it could run normally. Check out the compare resultComparisonState.simpleComparison()andcompareImages()method.simpleComparison()should be faster thancompareImages().Types of changes
Checklist