Implement BMP version compareImages_BMP() method for issue#153 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add alternative BMP comparison method
romankh3
requested changes
Apr 24, 2022
| public ImageComparisonResult compareImages_BMP() { | ||
|
|
||
| // check that the images have the same size | ||
| if (isImageSizesNotEqual(expected, actual)) { |
There was a problem hiding this comment.
This logic have code duplicate. Please. provide solution for using it from one place.
There was a problem hiding this comment.
I think adding a param to compareImages() method to indicate whether using the BMP version could help...
I mean I just tried to avoid "breaking change" at first.
Thanks for comments, I will check and fix the code for the near term.
| * | ||
| * @return the result of the drawing. | ||
| */ | ||
| public ImageComparisonResult compareImages_BMP() { |
There was a problem hiding this comment.
Please, rename method to be more java friendly.
For example compareImagesBMP or similar.
| * [work for issue #153] | ||
| * a class to store 3 bytes RGB values in a pixel | ||
| */ | ||
| private class RGB_tuple{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Related Issue
Motivation and Context
This work is aim to improve the performance of image-comparison, by getting RGB as bytes and removing binary operations in isDifferentPixels method.
How Has This Been Tested
Add a new test file called BMPTest.java, in which I designed some test to test feasibility and speed differernces.
Types of changes
Checklist