add logging to the projects for issue#132 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romankh3
reviewed
Sep 23, 2022
| @@ -45,19 +50,24 @@ public static BufferedImage readImageFromResources(String path) throws ImageComp | |||
| File imageFile = new File(path); | |||
| if (imageFile.exists()) { | |||
| try { | |||
| logger.info("Read image form User Successfully."); | |||
There was a problem hiding this comment.
Just because it's a library, we need to move lower logger level for it.
For example: info -> debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Add logging to the project. Well-formed and well-informed logging can help developers quickly locate the root cause when problems occur in the program.
Description
exceptionis the highest level. Theinfois the lowest level.Related Issue
Motivation and Context
Logging is necessary because it can record the error information, status information, debugging information, and execution time information generated when the program is running. In a production environment, logs are an important basis for finding the source of a problem.
How Has This Been Tested
Trigger some exception errors in the program and test the content of the logs of the exception.
Types of changes
Checklist