Solution for issue#190 #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romankh3
reviewed
Sep 23, 2022
| @@ -16,11 +16,18 @@ | |||
| import javax.imageio.ImageIO; | |||
| import javax.swing.ImageIcon; | |||
|
|
|||
|
|
|||
| /** | ||
| * Tools for the {@link ImageComparison} object. | ||
| */ | ||
| public final class ImageComparisonUtil { | ||
|
|
||
| public static int OFFSET = 0xff; | ||
| public static int EIGHT = 8; |
There was a problem hiding this comment.
That's the difference between EIGHT and TENSIX?
| @@ -64,4 +64,34 @@ | |||
| </plugin> | |||
| </plugins> | |||
| </build> | |||
|
|
|||
| <reporting> | |||
There was a problem hiding this comment.
Tell me please, for what reason you've added it?
romankh3
force-pushed
the
version-for-issue#190
branch
from
e27a49d to
89e24bc
Compare
|
Please, fix the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
To solve the problem in issue, I modify the formula to calculate the percentage of different pixels.
Description
I add a function
isDiffPixel()to return true if two pixels have the different RGBs, and in functiongetDifferencePercent(), the formula to calculate the percentage is 100 * diff pixels number / all pixels number.Related Issue
Motivation and Context
The original formula to calculate the percentage of different pixels is not intuitive and clear to the user. The new calculation formula makes it easier for users to know the number of different pixels.
How Has This Been Tested
Two tests are for the comparison with different images and the same images, I add a new assert to check the percentage of diff Pixels / all Pixels is right.
Types of changes
Checklist