Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat blank environment variables as nil #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yasseur1007
Copy link

@yasseur1007 yasseur1007 commented Jun 23, 2017

Consider blank variables as nil.

Useful when using "${ENV_VARIABLE}" way during the compile time, that is converted to "" when no env found at run time.

@romul
Copy link
Owner

romul commented Jun 23, 2017

Hello, @yasseur1007! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@romul
Copy link
Owner

romul commented Jun 23, 2017

Ebert has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/romul/newrelic.ex/pulls/9.

@yasseur1007
Copy link
Author

hi @romul can you have a look at this PR?
also i'm not sure the Ebert issue found is related to the changes i've made :)

@sb8244
Copy link
Collaborator

sb8244 commented Aug 19, 2019

Hi @yasseur1007. This is an old PR, but I'm wondering if you still need this functionality? If so, we can look at adding it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants