feat(WBTC, LegacyTokenMigrator): add new WBTC, add Legacy Token Migrator #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _disableInitializers(); | ||
| } | ||
|
|
||
| function initialize(address admin, address[] calldata legacyTokens, address[] calldata newTokens) external initializer { |
There was a problem hiding this comment.
Should check with legal to see if the upgradable pattern is allowed, since this contract holds funds
|
|
||
| // Mint the new token if the contract balance is insufficient | ||
| uint256 selfBalance = IERC20(newToken).balanceOf(address(this)); | ||
| if (selfBalance < amount) { |
There was a problem hiding this comment.
If the selfBalance is zero, should mint directly to user
There was a problem hiding this comment.
no need to handle for that explicit logic
vovikhangcdv
approved these changes
Jan 17, 2025
khangvv
approved these changes
Jan 17, 2025
khangvv
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds implement for new WBTC and Legacy Token Migrator.
Checklist