Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: don't add basefee to treasury in system transaction in tracing #24

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

minh-bq
Copy link
Contributor

@minh-bq minh-bq commented Feb 26, 2025

As the system transaction does not follow the basefee rule, make this behavior consistent in tracing path. This commit also refactors the code the skip the whole transaction's epilogue for system transaction in tracing.

As the system transaction does not follow the basefee rule, make this behavior
consistent in tracing path. This commit also refactors the code the skip the
whole transaction's epilogue for system transaction in tracing.
Copy link
Collaborator

@huyngopt1994 huyngopt1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM

@huyngopt1994 huyngopt1994 merged commit 0ce57fd into ronin-chain:master Feb 27, 2025
1 check passed
huyngopt1994 pushed a commit that referenced this pull request Feb 27, 2025
…24)

As the system transaction does not follow the basefee rule, make this behavior
consistent in tracing path. This commit also refactors the code the skip the
whole transaction's epilogue for system transaction in tracing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants