fix: expo 52 and react navigation 7 #432
Draft
+41
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyhw
commented
Nov 18, 2024
|
|
||
| type ButtonProps = { | ||
| title: string; | ||
| } & TouchableOpacityProps; | ||
|
|
||
| export const Button = forwardRef<TouchableOpacity, ButtonProps>(({ title, ...touchableProps }, ref) => { | ||
| export const Button = forwardRef<View, ButtonProps>(({ title, ...touchableProps }, ref) => { |
There was a problem hiding this comment.
This was erroring because TouchableOpacity's seems to have changed and is no longer a type its just a value (function)
dannyhw
commented
Nov 18, 2024
| @@ -1,7 +1,7 @@ | |||
| import { Theme } from '@react-navigation/native'; | |||
| import { COLORS } from './colors'; | |||
|
|
|||
| const NAV_THEME: { light: Theme; dark: Theme } = { | |||
| const NAV_THEME: { light: Partial<Theme>; dark: Partial<Theme> } = { | |||
There was a problem hiding this comment.
something is going on here, we maybe need to put fonts in the theme now
import { DefaultTheme, Theme } from '@react-navigation/native';
// could go like this??
light: {
fonts: DefaultTheme.fonts,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):