Skip to content

Commit

Permalink
fixup! make waveform_zoom a ControlPotmeter to simplify mapping to …
Browse files Browse the repository at this point in the history
…potmeters
  • Loading branch information
ronso0 committed Feb 1, 2025
1 parent f0542c0 commit 4e068f4
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions src/preferences/dialog/dlgprefwaveform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,7 @@ void DlgPrefWaveform::updateWaveformAcceleration(

useAccelerationCheckBox->blockSignals(false);
}

void DlgPrefWaveform::updateWaveformOption(bool useWaveform,
WaveformWidgetBackend backend,
allshader::WaveformRendererSignalBase::Options currentOptions) {
Expand Down Expand Up @@ -561,9 +562,19 @@ void DlgPrefWaveform::slotSetWaveformOverviewType() {

void DlgPrefWaveform::slotSetDefaultZoom(int index) {
WaveformWidgetFactory::instance()->setDefaultZoom(index + 1);
for (int i = 1; i <= PlayerManager::numDecks(); i++) {
QStringList groups;
for (unsigned int i = 1; i <= PlayerManager::numDecks(); i++) {
groups.append(QStringLiteral("[Channel%1]").arg(i));
}
for (unsigned int i = 1; i <= PlayerManager::numSamplers(); i++) {
groups.append(QStringLiteral("[Sampler%1]").arg(i));
}
for (unsigned int i = 1; i <= PlayerManager::numPreviewDecks()(); i++) {

Check failure on line 572 in src/preferences/dialog/dlgprefwaveform.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 24.04

expression cannot be used as a function

Check failure on line 572 in src/preferences/dialog/dlgprefwaveform.cpp

View workflow job for this annotation

GitHub Actions / clazy

called object type 'unsigned int' is not a function or function pointer

Check failure on line 572 in src/preferences/dialog/dlgprefwaveform.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 x64

called object type 'unsigned int' is not a function or function pointer

Check failure on line 572 in src/preferences/dialog/dlgprefwaveform.cpp

View workflow job for this annotation

GitHub Actions / coverage

expression cannot be used as a function

Check failure on line 572 in src/preferences/dialog/dlgprefwaveform.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 arm64

called object type 'unsigned int' is not a function or function pointer

Check failure on line 572 in src/preferences/dialog/dlgprefwaveform.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

term does not evaluate to a function taking 0 arguments
groups.append(QStringLiteral("[PreviewDeck%1]").arg(i));
}
for (const QString& group : std::as_const(groups)) {
ControlObject* pControl = ControlObject::getControl(
QStringLiteral("[Channel%1]").arg(i), QStringLiteral("waveform_zoom"));
group, QStringLiteral("waveform_zoom"));
DEBUG_ASSERT(pControl);
pControl->setDefaultValue(index + 1);
}
Expand Down

0 comments on commit 4e068f4

Please sign in to comment.