Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owen/bitseed validity 4 #1776

Merged
merged 13 commits into from
Jun 23, 2024
Merged

Conversation

yubing744
Copy link
Collaborator

@yubing744 yubing744 commented May 31, 2024

Summary

Add validity integration test for mint tick operation

  • Upgrade bitseed image to v0.1.6
  • Fix bitcoin module tx_to_height logic error
  • cbor module supports map to cbor
  • moveos-wasm module removes prohibit_ops function

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 4:01pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2024 4:01pm

@yubing744
Copy link
Collaborator Author

yubing744 commented Jun 11, 2024

@jolestar @steelgeek091
Running the cpp version of generator.wasm will result in the following error:
image

If the prohibited instruction is replaced with the Unreachable instruction, the following error will appear when running the cpp version of generator.wasm:
image

@steelgeek091
Copy link
Collaborator

steelgeek091 commented Jun 12, 2024

@jolestar @steelgeek091 Running the cpp version of generator.wasm will result in the following error: image

If the prohibited instruction is replaced with the Unreachable instruction, the following error will appear when running the cpp version of generator.wasm: image

说明 cpp wasm 源码里用到了 c++ 运行时的多态,bitseed 的 Rust 版本 generator 应该也用了 dyn trait。
看到代码里的 host function 实现中传递了 gas meter,那直接增加在 host function 中的计费即可,不用禁止 CallIndirect。

@yubing744
Copy link
Collaborator Author

@jolestar help review.

@jolestar jolestar merged commit f24d3c6 into rooch-network:main Jun 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants