Make prefix work properly when querying and updating version #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to look at this tonight. Seems reasonable. |
|
Also, regarding your side note: I'm finding that the tests fail on Java 11 due to fipp (a transitive dependency of midje). I've updated that dependency and now tests work on java 8 and java 11. Let me know what you see. |
|
Unfortunately 27 tests are failing for me with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using prefix in project.clj doesn't work properly:
The problem is that the prefix is only added when creating a tag, not checked when querying for current version or updating the version. This PR fixes that by forwarding the config (and thus, the prefix) to the code that checks the version.
Side note - I was not able to run any tests.