[cling-cpt] Reducing global variable mutaiton [skip-ci] #10883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change occurred as it was mentioned in the meta issue list, so all the functions that use a global variable were moved to the Cpt class, and all the globals are now instance variables of the Cpt class, except for clangdir and llvm_flags, as it was unneccesary to change those. It is now much easier to debug the code, as there is way less global mutation occuring.
…nctions in the Cpt class
|
Can one of the admins verify this patch? |
Axel-Naumann
requested review from
vgvassilev
and removed request for
Axel-Naumann
|
I think this PR is not going in the direction of resolving the underlying issue. The idea in the issue, iiuc, is that we have variables (on the global scope) which were mutated by a lot of functions. Moving these variables to become class variables does not solve the mutation problems. I think a viable way forward is to teach functions not use global variables but to pass these global variables as parameters. This way we will know which function requires what state. Then we can think how to refactor it further. |
|
Thank you I'll work on it |
|
I'll close this pull request and make a new one with the parameter passing style you mentioned @vgvassilev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Reduces global variable mutation, and is now easier to debug.
Changes or fixes: Created a new Cpt class, moved all functions that use global variables to this class, and then made all the globals instance variables of the Cpt class.
Checklist:
This PR fixes issue mentioned in the meta-issue list #406 (root-project/cling#406).