[cling-cpt] Split long lines to get rid of E501 error [skip-ci] #11010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Will make more pull requests to fully get rid of the E501 error |
Comment on lines
1926
to
1927
| "sudo {0} -m pip" + | ||
| " install distro".format(sys.executable), shell=True |
There was a problem hiding this comment.
I'd suggest to split at the , to avoid breaking the string literal (same below, where it applies).
Comment on lines
2310
to
2312
| #download_llvm_binary() | ||
| #compile = compile_for_binary | ||
| #install_prefix = install_prefix_for_binary |
There was a problem hiding this comment.
Why this additional change? It's not part of the PR description.
vgvassilev
approved these changes
Aug 3, 2022
|
@saisoma123, can you rebase this PR? |
1 task
|
@vgvassilev Yeah I think there is a way for automatic linting I'll do that instead. I'll also rebase the PR right now |
|
Yeah just rebased the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Makes the code more flake8 compliant.
Changes or fixes: Split lines that were longer than 79 characters.
Checklist:
This PR fixes issue #406 mentioned in (root-project/cling#406)