Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cling-cpt] Formatted the beginning functions of the cpt [skip-ci] #11140

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[cling-cpt] Formatted the beginning functions of the cpt [skip-ci] #11140

merged 1 commit into from
Aug 21, 2024

Conversation

saisoma123
Copy link
Contributor

This Pull request: Makes the code more flake8 compliant

Changes or fixes: Automatically split the lines and fixed other errors

Checklist:

  • tested changes locally
  • [NA] updated the docs (if necessary)

This PR fixes #406 mentioned in meta-issue list (root-project/cling#406)

@saisoma123 saisoma123 requested a review from vgvassilev as a code owner August 8, 2022 00:49
@phsft-bot
Copy link

Can one of the admins verify this patch?

@saisoma123 saisoma123 closed this Aug 15, 2022
@saisoma123 saisoma123 reopened this Aug 15, 2022
@Axel-Naumann Axel-Naumann removed their assignment Aug 24, 2022
@guitargeek guitargeek closed this Aug 21, 2024
@guitargeek guitargeek reopened this Aug 21, 2024
guitargeek
guitargeek approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have verified that this change indeed reduces the amount of flake8 warnings and that the changes are purely style related.

@guitargeek guitargeek merged commit f8bff5b into root-project:master Aug 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek approved these changes

@vgvassilev vgvassilev Awaiting requested review from vgvassilev vgvassilev is a code owner

Assignees

@vgvassilev vgvassilev

Labels
in:Cling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saisoma123 @phsft-bot @guitargeek @Axel-Naumann @vgvassilev @ferdymercury