-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hopefully, fix the long-standing problem with h2root #15915
base: master
Are you sure you want to change the base?
Conversation
Test Results 18 files 18 suites 4d 11h 9m 38s ⏱️ For more details on these failures, see this check. Results for commit e052758. ♻️ This comment has been updated with latest results. |
As far as I can tell, this shouldn't make a difference because root/misc/minicern/src/hbook.f Lines 260 to 263 in 80023e0
|
@hahnjo it made on on MacOS. (long debug) |
my comment from #15915 (comment) still stands: based on the code, there should be no change in behavior because |
I know "c" is supposed to be the default, but this change made a difference on Mac when I debugged it a while ago. I guess it is worth merging. |
Using the C option (meaning C I.O) in hropen seems to fix the issue on Mac.