[ntuple] Ensure type name given by RField<T> is renormalized #17986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 5d 5h 3m 29s ⏱️ For more details on these failures, see this check. Results for commit 209a806. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Mar 16, 2025
pcanal
reviewed
Mar 16, 2025
hahnjo
requested changes
Mar 17, 2025
vepadulano
force-pushed
the
rntuple-renormalize-demangled-name
branch
from
950713d to
f6566b3
Compare
pcanal
reviewed
Mar 20, 2025
To avoid inconsistencies between the full type name of a custom class reported by the RNTuple IO and the type name reported by ROOT meta. The commit adds a unittest. Previously, the test would fail with exceptions such as: ``` 321: unknown file: Failure 321: C++ exception with description "type mismatch for field f2: DataVector<std::int32_t,std::vector<CustomStruct>> vs. DataVector<int,vector<CustomStruct> > 321: At: 321: void ROOT::Experimental::REntry::EnsureMatchingType(RFieldToken) const [with T = DataVector<int, std::vector<CustomStruct> >] 321: " thrown in the test body. ``` Co-authored-by: Jonas Hahnfeld <[email protected]>
vepadulano
force-pushed
the
rntuple-renormalize-demangled-name
branch
from
f6566b3 to
209a806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid inconsistencies between the full type name of a custom class reported by the RNTuple IO and the type name reported by ROOT meta. The commit adds a unittest. Previously, the test would fail with exceptions such as: