[RF] Dump debug macro from codegen on compilation failure #18063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also run `stressRooFit` with codegen backends, excluding the tests that are not supported yet. This increases test coverage quite a bit, and means we can remove some test from `testRooFuncWrapper`. It was based on the same tutorial that the stressRooFit test is based on.
Test Results 19 files 19 suites 4d 16h 57m 50s ⏱️ Results for commit 2ec0fcc. |
lcanal00
previously approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping the generated code in case it fails to compile greatly helps in development and debugging of the new RooFit code generation backend.
This will be useful during the upcoming CMS CAT hackathon, where we work on supporting the models from CMS Combine with the codegen backend.
Also, run parts of the
stressRooFittest suite with the codegen backend, which increases test coverage and also allows us to remove a redundant test.