Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webgui] more use of <jsroot-importmap> #18097

Merged
merged 6 commits into from
Mar 24, 2025
Merged

[webgui] more use of <jsroot-importmap> #18097

merged 6 commits into from
Mar 24, 2025

Conversation

linev
Copy link
Member

@linev linev commented Mar 21, 2025

Such map automatically inserted in HTML file by THttpServer if <!--jsroot_importmap--> comment
appears in HTML file.

  1. Better formatting of produced output - detect indentation
  2. Include several JSROOT modules which can be used
  3. Use importmap in most files and tutorials
  4. Also in JSROOT use it and fix histogram type for TGraph/TGraph2D drawing

linev added 6 commits March 21, 2025 16:11
@linev
[http] buitify <--jsroot_importmap--> output
2072326 
Apply better spacing to see nice output when inspecting source code of the web page
@linev
[http] Add several modules to <!--jsroot_importmap-->
d515fe6 
Let directly load d3.mjs and three_addons.mjs
@linev
[http] use jsroot importmap in tutorials
eba2e7b 
Instead of jsrootsys path use functionality of jsroot-map
@linev
[webgui] use <!--jsroot_importmap--> in documentation
04e0551
@linev
[webgui] use <!--jsroot_importmap--> in all widgets
178b50b
@linev
[jsroot] dev 21/03/2025
693ee6b 
1. Use <!--jsroot_importmap--> in htm files and docu
2. Use proper TH1F/TH2F classes when draw TGraph
@linev linev requested a review from bellenot March 21, 2025 15:51
@linev linev self-assigned this Mar 21, 2025
@linev linev requested a review from couet as a code owner March 21, 2025 15:51
bellenot
bellenot approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the builds are green

@github-actions GitHub Actions
Copy link

Test Results

    20 files      20 suites   5d 11h 6m 19s ⏱️
 2 726 tests  2 725 ✅ 0 💤 1 ❌
52 638 runs  52 637 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 693ee6b.

vepadulano
vepadulano requested changes Mar 23, 2025
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs checking

@pcanal pcanal dismissed a stale review March 23, 2025 15:30

Please tell us why you approve this request.

@linev
Copy link
Member Author

linev commented Mar 24, 2025

Needs checking

@vepadulano That kinds of checking?

vepadulano
vepadulano approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@linev linev merged commit ad180b5 into root-project:master Mar 24, 2025
21 of 24 checks passed
@linev linev deleted the jsroot_modules branch March 24, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot bellenot approved these changes

@vepadulano vepadulano vepadulano approved these changes

@couet couet Awaiting requested review from couet couet is a code owner

Assignees

@linev linev

Labels
affects:master in:WebGui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linev @bellenot @vepadulano