[df] Refresh input TTree when changing spec #18412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-between distributed tasks the input data source of the RDataFrame is changed (via RLoopManager::ChangeSpec), thus invalidating the input TTree from the previous task. Ensure the Snapshot action helper is always aware of the latest, currently valid TTree by retrieving it from the input RLoopManager directly. This fixes the failures in the graph caching test. The test was also extended to check that the output snapshot from the distributed tasks also contains the right data as it was read from the input TTree.
vepadulano
force-pushed
the
rdf-refresh-tree-after-change-spec
branch
from
3a9a358 to
f42933d
Compare
Test Results 17 files 17 suites 4d 10h 30m 22s ⏱️ For more details on these failures, see this check. Results for commit 7fe4188. ♻️ This comment has been updated with latest results. |
Since TTree is handled via RDataSource now, we can directly access the data source object in cling::printValue(ROOT::RDataFrame *).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-between distributed tasks the input data source of the RDataFrame is changed (via RLoopManager::ChangeSpec), thus invalidating the input TTree from the previous task. Ensure the Snapshot action helper is always aware of the latest, currently valid TTree by retrieving it from the input RLoopManager directly.
This fixes the failures in the graph caching test. The test was also extended to check that the output snapshot from the distributed tasks also contains the right data as it was read from the input TTree.