Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[histv7] New benchmarks for RHist and THist #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claireguyot
Copy link
Contributor

No description provided.

…RECISIONS (double, float, int, long long) when possible.
@oshadura
Copy link
Collaborator

oshadura commented Apr 22, 2020

@claireguyot I am not sure if you can see logs (please let me know if you can't):

/home/travis/build/root-project/rootbench/root/hist/hist/RHistFillLongLongBenchmarks.cxx: In function ‘void BM_RHist_FillN_LongLong(benchmark::State&)’:
/home/travis/build/root-project/rootbench/root/hist/hist/RHistFillLongLongBenchmarks.cxx:117:141: error: no matching function for call to ‘ROOT::Experimental::RHist<2, long int, ROOT::Experimental::RHistStatContent>::FillN(std::__ROOT::span<const ROOT::Experimental::Hist::RCoordArray<2> >, std::__ROOT::span<const long long int>)’

       hist->FillN(std::span<const CoordArray_t>(&coords[0], nbOfDataPoints), std::span<const long long>(&weightsLongLong[0], nbOfDataPoints));
                                                                                                                                             ^
In file included from /home/travis/build/root-project/rootbench/root/hist/hist/RHistFillLongLongBenchmarks.cxx:1:0:
/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/rootcov/Mon/ROOT/HEAD-81048/x86_64-ubuntu1604-gcc54-opt/include/ROOT/RHist.hxx:144:9: note: candidate: void ROOT::Experimental::RHist<DIMENSIONS, PRECISION, STAT>::FillN(std::__ROOT::span<const typename ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<DIMENSIONS, PRECISION, std::vector<PRECISION>, STAT ...> >::CoordArray_t>, std::__ROOT::span<const PRECISION>) [with int DIMENSIONS = 2; PRECISION = long int; STAT = {ROOT::Experimental::RHistStatContent}; typename ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<DIMENSIONS, PRECISION, std::vector<PRECISION>, STAT ...> >::CoordArray_t = ROOT::Experimental::Hist::RCoordArray<2>]
    void FillN(const std::span<const CoordArray_t> xN, const std::span<const Weight_t> weightN) noexcept
         ^
/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/rootcov/Mon/ROOT/HEAD-81048/x86_64-ubuntu1604-gcc54-opt/include/ROOT/RHist.hxx:144:9: note:   no known conversion for argument 2 from ‘std::__ROOT::span<const long long int>’ to ‘std::__ROOT::span<const long int>’

/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/rootcov/Mon/ROOT/HEAD-81048/x86_64-ubuntu1604-gcc54-opt/include/ROOT/RHist.hxx:150:9: note: candidate: void ROOT::Experimental::RHist<DIMENSIONS, PRECISION, STAT>::FillN(std::__ROOT::span<const typename ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<DIMENSIONS, PRECISION, std::vector<PRECISION>, STAT ...> >::CoordArray_t>) [with int DIMENSIONS = 2; PRECISION = long int; STAT = {ROOT::Experimental::RHistStatContent}; typename ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<DIMENSIONS, PRECISION, std::vector<PRECISION>, STAT ...> >::CoordArray_t = ROOT::Experimental::Hist::RCoordArray<2>]

    void FillN(const std::span<const CoordArray_t> xN) noexcept { fImpl->FillN(xN); }

         ^
/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/rootcov/Mon/ROOT/HEAD-81048/x86_64-ubuntu1604-gcc54-opt/include/ROOT/RHist.hxx:150:9: note:   candidate expects 1 argument, 2 provided
root/hist/hist/CMakeFiles/RHistBenchmarks.dir/build.make:101: recipe for target 'root/hist/hist/CMakeFiles/RHistBenchmarks.dir/RHistFillLongLongBenchmarks.cxx.o' failed
make[2]: *** [root/hist/hist/CMakeFiles/RHistBenchmarks.dir/RHistFillLongLongBenchmarks.cxx.o] Error 1
CMakeFiles/Makefile2:1565: recipe for target 'root/hist/hist/CMakeFiles/RHistBenchmarks.dir/all' failed
make[1]: *** [root/hist/hist/CMakeFiles/RHistBenchmarks.dir/all] Error 2
Makefile:94: recipe for target 'all' failed

@oshadura
Copy link
Collaborator

@Axel-Naumann can you please take a look in a free time what can be done here? Or whom I can assign this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants