-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory instrumentation support #197
Open
vgvassilev
wants to merge
4
commits into
root-project:master
Choose a base branch
from
vgvassilev:add_memory_instrumentation_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add memory instrumentation support #197
vgvassilev
wants to merge
4
commits into
root-project:master
from
vgvassilev:add_memory_instrumentation_support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
add_memory_instrumentation_support
branch
2 times, most recently
from
October 12, 2020 10:59
5205fa0
to
dae8452
Compare
ping |
@vgvassilev sorry! I am here finally, can I ask you to rebase please? |
vgvassilev
force-pushed
the
add_memory_instrumentation_support
branch
from
December 3, 2020 15:46
dae8452
to
7f49792
Compare
@vgvassilev if you will rebase on master again, GH Actions with root-nightlies from conda will be retriggered 👍 |
That will help us when creating C libraries.
vgvassilev
force-pushed
the
add_memory_instrumentation_support
branch
from
December 3, 2020 18:58
7f49792
to
f21c2b5
Compare
Done |
vgvassilev
force-pushed
the
add_memory_instrumentation_support
branch
from
December 4, 2020 11:29
f21c2b5
to
baf7db3
Compare
|
vgvassilev
force-pushed
the
add_memory_instrumentation_support
branch
from
December 4, 2020 11:51
baf7db3
to
03f6ef1
Compare
It implements a C library which records information about the memory allocations. The library is loaded using the LD_PRELOAD mechanism (and DYLD_INSERT_LIBRARIES for osx). GoogleBenchmark displays the memory allocation results are only in the json format. For instance: DYLD_FORCE_FLAT_NAMESPACE=1 DYLD_INSERT_LIBRARIES=./lib/Instrumentation/libRBInstrumentation.dylib ./root/interpreter/InterpreterLookupHelperBenchmarks --benchma rk_format=json: ... { "name": "BM_LookupHelper_Leak", "run_name": "BM_LookupHelper_Leak", "run_type": "iteration", "repetitions": 0, "repetition_index": 0, "threads": 1, "iterations": 1, "real_time": 1.3199219449888916e+09, "cpu_time": 8.0450300000000000e+08, "time_unit": "ns", "allocs_per_iter": 6.0000000000000000e+00, "max_bytes_used": 3368 }
vgvassilev
force-pushed
the
add_memory_instrumentation_support
branch
from
December 4, 2020 12:38
03f6ef1
to
7e06ec2
Compare
@vgvassilev I check CI logs and I see segfault :(
If you will have time can you rebase please here? |
I can reproduce the failure. I do not know what's going on and I will have to fix it before landing it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of a rootbench memory tracing library.
It implements a C library which records information about the memory allocations. The library is loaded using the LD_PRELOAD mechanism (and DYLD_INSERT_LIBRARIES for osx).
GoogleBenchmark displays the memory allocation results are only in the json format. For instance: