Upgrade deps #28
Open
Upgrade deps #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahdinosaur
reviewed
Jul 7, 2018
| function initEpic (action$) { | ||
| return of(signIn(createCid())) | ||
| // .pipe( | ||
| // delay(0) // apparently needs delay otherwise action lost |
There was a problem hiding this comment.
are we sure about removing this?
There was a problem hiding this comment.
no i am not sure 😅 everything seems to be working without it, i see the SIGN_IN actions i expect to see, but perhaps you have more context there @ahdinosaur ?
There was a problem hiding this comment.
i see now this makes sense given https://github.com/root-systems/dogstack/pull/94/files#diff-dc95763c07fd52f14992f99a416bc054R46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrades the lib dependencies to latest stable versions
major changes:
authentication/epic