-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom-property-pattern
rule changed for compatibility with WP naming
#2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellymears
reviewed
Jan 3, 2024
We will want to make this change here, because it is a WordPress specific rule and should not be applied to everyone using sass with bud.js. |
@kellymears moved |
Okay, I ran some tests on this and it's looking good. Can you add the following test to import * as stylelint from 'stylelint'
import {describe, expect, it} from 'vitest'
describe(`@roots/bud-preset-wordpress/stylelint`, () => {
it(`should error without rule`, async () => {
const result = await stylelint.lint({
code: `
.foo {
color: var(--wp--preset--color--primary);
}
`,
config: {
extends: [
`@roots/bud-sass/stylelint-config`,
],
},
})
expect(result.errored).toBe(true)
})
it(`should not error with rule`, async () => {
const result = await stylelint.lint({
code: `
.foo {
color: var(--wp--preset--color--primary);
}
`,
config: {
extends: [
`@roots/bud-sass/stylelint-config`,
`@roots/bud-preset-wordpress/stylelint`,
],
},
})
expect(result.errored).toBe(false)
})
}) |
kellymears
reviewed
Jan 8, 2024
thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
MAJOR: breaking change
fix #2538