Featute/Sign Up UI #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfiamene
reviewed
Aug 16, 2023
| && password.isNotEmpty() && !showPasswordError && | ||
| confirmPassword.isNotEmpty() && !showConfirmPasswordError | ||
| } | ||
| } |
There was a problem hiding this comment.
please don't forget to add a new line here
sfiamene
reviewed
Aug 16, 2023
| @Preview | ||
| @Composable | ||
| fun SignUpScreen( | ||
| viewModel: SignUpViewModel = SignUpViewModel(), |
There was a problem hiding this comment.
don't we have any DI framework into the base yet? if so, might be better to use it. What do you think?
hrodrick
reviewed
Aug 16, 2023
| <string name="sign_up_name_error">Name not valid</string> | ||
| <string name="sign_up_confirm_password_label">Confirm Password</string> | ||
| <string name="sign_up_confirm_password_error">Passwords don\'t match</string> | ||
| <string name="sign_up_button">SIGN UP</string> |
There was a problem hiding this comment.
Please capitalize only first letter Sign up. Then use .uppercase() in the code if needed
hrodrick
reviewed
Aug 16, 2023
Comment on lines
+20
to
+21
| import com.rootstrap.androidcomposebase.ui.pages.sign_up.SignUpScreen | ||
| import com.rootstrap.androidcomposebase.ui.pages.sign_up.SignUpViewModel |
There was a problem hiding this comment.
remove this if not needed.
Comment on lines
+4
to
+11
| val name: String = "", | ||
| val showNameError: Boolean = false, | ||
| val email: String = "", | ||
| val showEmailError: Boolean = false, | ||
| val password: String = "", | ||
| val showPasswordError: Boolean = false, | ||
| val confirmPassword: String = "", | ||
| val showConfirmPasswordError: Boolean = false, |
There was a problem hiding this comment.
I'd rename:
name -> nameInput
email -> emailInput
password -> passwordInput
confirmPassword -> confirmPasswordInput
| import kotlinx.coroutines.flow.update | ||
| import java.util.regex.Pattern | ||
|
|
||
| class SignUpViewModel : ViewModel() { |
There was a problem hiding this comment.
before merging wait for the previous PR
#57
and reuse the state management logic,
if need more context write to @agustinkoll-rootstrap
amaury901130
requested changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE [#6]
Description
Tasks
SignUpScreenSIGN UPbuttonSignUpViewModelPreview
device-2023-08-16-150431.mp4
Notes