Fix rspec-rails gem issues

[bigchickenwings]

Description:

Currently, cloning this repository, running the setup command, and then running the specs don't work.

Arctic Admin related issues (Caused by rspec-rails):

The system specs don't work as-is. It throws the following error:

ActionView::Template::Error:
   Error: File to import not found or unreadable: arctic_admin/src/scss/main.
             on line 11:1 of app/assets/stylesheets/active_admin.scss
   >> @import 'arctic_admin/src/scss/main';
      ^
# ./app/assets/stylesheets/active_admin.scss:11
# ------------------
# --- Caused by: ---
# SassC::SyntaxError:
#   Error: File to import not found or unreadable: arctic_admin/src/scss/main.
#           on line 11:1 of app/assets/stylesheets/active_admin.scss
#   >> @import 'arctic_admin/src/scss/main';
#      ^
#   ./app/assets/stylesheets/active_admin.scss:11

This happens because we are adding the arctic_admin through package.json instead of adding it as a gem. Therefore, we need to run bundle exec rails assets:precompile before running our specs.

If we move the rspec-rails gem to both the :development and :test environments, this will be done automatically for us, as mentioned by @santib

With these changes, the API will always work on newly-cloned environments, without needing additional setup.

---

Preview:

Before:

After:

[santib]

Hi @bigchickenwings thanks for the report.

spring

I'm ok removing it. I actually have it completely disabled in my dev env because it brings more problems than solutions to me. If we are going to remove it, there are more places that need to be changed, try doing git grep -i spring to find all places. cc @JulianPasquale @guillermoap

arctic_admin

It works fine for me (and also in the CI). I think you might be missing doing bundle exec rails assets:precompile since we are installing arctic_admin through the package.json instead of the Gemfile. That said, I think it should be called automatically, but seems that there is something off with RSpec cc @PerezIgnacio

[bigchickenwings]

Hi, @santib

Nice catch, I didn't run bundle exec rails assets:precompile. Running it does make the specs pass.

Any reason behind this decision? This is of course a matter of personal preference, but I do prefer to not have to run bundle exec rails assets:precompile on development and test environments 👀

[santib]

but I do prefer to not have to run bundle exec rails assets:precompile on development and test environments 👀

@bigchickenwings yes, it should be ran automatically. Not sure why it's not happening, maybe it's related to the issue I shared above. But it'd be good to fix it (maybe it's a fix in rspec-rails?).

UPDATE:
If we move the rspec-rails gem to the development + test group, we can then use bin/rails spec and it will automatically precompile assets

[bigchickenwings]

@santib done! Thanks for the help 😄

Let me know if there's anything else I should address on this PR.

[santib]

@santib done! Thanks for the help 😄

Let me know if there's anything else I should address on this PR.

Would you mind making 2 separate PRs with the appropriate titles?

One for improving the rspec-rails setup, and the other to remove Spring (also check for more places where it needs to be removed). This way we can review and have conversations on each of them individually and eventually merge them once they are ready without blocking each other. For example the rspec-rails change will probably be easily accepted, the removal of spring may require some discussion.

[bigchickenwings]

@santib updated this one to handle rspec-rails only.

Will be creating the spring one later today 🚀

[santib]

Thanks @bigchickenwings 🙌