This repository has been archived by the owner on Aug 23, 2022. It is now read-only.
JOSS review #143
Merged
JOSS review #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'review' of github.com:CC-HIC/cleanEHR: move ggplot and pander to suggest
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 66.48% 75.31% +8.82%
==========================================
Files 20 14 -6
Lines 1292 1268 -24
==========================================
+ Hits 859 955 +96
+ Misses 433 313 -120
Continue to review full report at Codecov.
|
dpshelio
reviewed
Aug 25, 2017
| #' This is a member function of ccTable-class. Using create_cctable is a safer and | ||
| #' easier way to create the ccTable. See create_cctable. | ||
| #' @name ccTable_create_cctable | ||
| NULL |
There was a problem hiding this comment.
what does this NULL does?
There was a problem hiding this comment.
Because refclass doesn't have a proper way to document. NULL means it is an orphan document which doesn't link to anywhere.
dpshelio
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.