Parse Works objects publication_date field as date type
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as.Date()conversion of thepublication_dategets the job done but is clunky and applied very narrowly.I went through the API docs and there are only the two other places where the API returns date values:
updated_dateandcreated_date. These are OpenAlex-specific metadata andoa2df()sometimes returns them depending on the entity. I have less thoughts on these guys.Date values aren't automatically converted by the JSON parser, like how integer/double/logical/etc. are - not sure if we want a bigger discussion around that (but perhaps at least not at this stage, given how rare date fields are?)