Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A search vignette #289

Merged
merged 3 commits into from
Oct 16, 2024
Merged

A search vignette #289

merged 3 commits into from
Oct 16, 2024

Conversation

trangdata
Copy link
Collaborator

addresses part of #287

yjunechoe
yjunechoe approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@yjunechoe yjunechoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor clarification question (because I personally don't use search much, so I genuinely don't know!)

vignettes/articles/literature-search.Rmd Outdated Show resolved Hide resolved
@trangdata trangdata merged commit 42f4d16 into main Oct 16, 2024
7 checks passed
@trangdata trangdata deleted the lit-search branch October 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjunechoe yjunechoe yjunechoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trangdata @yjunechoe