Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to httr2 #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Switch to httr2 #313

wants to merge 2 commits into from

Conversation

raffaem
Copy link
Contributor

@raffaem raffaem commented Feb 2, 2025

No description provided.

@raffaem
Copy link
Contributor Author

raffaem commented Feb 2, 2025

httr is superseded.

See https://httr.r-lib.org/

@yjunechoe
Copy link
Collaborator

Thanks for opening the PR. I'm not opposed to this (in fact it'd be awesome if this could be done seamlessly/effortlessly!), but if this is still in progress would you mind converting this PR to a draft and pinging us later by marking it ready to review? (ex: when all tests pass?)

I'll also just note that despite "superseded" sounding like a scary word, it's not critical for functionality:

In some ways a superseded function is actually safer than a stable function because it’s guaranteed never to change

To reiterate, it'd be awesome if you'd be willing to put in the time and effort to see this PR through! But I also just wanted to be transparent about the fact that we are indeed aware of {httr2} but have simply determined it to be not a priority the last time this was raised.

@raffaem raffaem marked this pull request as draft February 4, 2025 09:32
@raffaem
Copy link
Contributor Author

raffaem commented Feb 4, 2025

I'm not so knowledgeable about R packages.

I converted this to a draft.

The tests already don't pass without the PR, I opened an issue about it

@raffaem raffaem marked this pull request as ready for review February 7, 2025 23:56
@raffaem
Copy link
Contributor Author

raffaem commented Feb 10, 2025

Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants