Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set encoding to UTF-8 for tags and user names #347

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Set encoding to UTF-8 for tags and user names #347

merged 4 commits into from
Jul 25, 2024

Conversation

jmaspons
Copy link
Collaborator

FIX #346

@jmaspons jmaspons requested a review from mpadge July 24, 2024 06:01
mpadge
mpadge reviewed Jul 24, 2024
View reviewed changes
jmaspons and others added 3 commits July 24, 2024 09:44
@jmaspons @mpadge
More explicit and efficient
a81f652 
Co-authored-by: mark padgham <[email protected]>
@jmaspons
Use enc2utf8() instead of Encoding() <- "UTF-8"
6e7336e 
Tests show better performance, see #346
enc2utf8() in matrices where possible to avoid calls for each df column
@jmaspons
Set encoding in the getbb() result
2ff8526
@jmaspons jmaspons mentioned this pull request Jul 25, 2024
Closed
mpadge
mpadge approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks so much @jmaspons! Feel free to merge anytime

@jmaspons jmaspons merged commit c4bd595 into main Jul 25, 2024
6 checks passed
@jmaspons jmaspons deleted the encoding_UTF8 branch July 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set encoding to UTF8 for returned data
2 participants
@jmaspons @mpadge