Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated function documentation for fetch_survey() #285

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

jmobrien
Copy link
Collaborator

@jmobrien jmobrien commented Sep 7, 2022

@juliasilge feel free to review/edit this. I tried to be detailed to address various known issues/points of confusion, but that does make the text rather long. I welcome any insight on consolidation (or errors!)

Holding off on rebuilding docs until review, but that can be added before merge.

@jmobrien
Copy link
Collaborator Author

jmobrien commented Sep 7, 2022

Will close #265

Copy link
Collaborator

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely long, but I think it's all useful and important information. Let's try this and see if folks find it too difficult to parse (we could edit later and maybe move this to a vignette or similar, if needed).

@juliasilge juliasilge merged commit a55493b into master Sep 9, 2022
@juliasilge juliasilge deleted the fetch-survey-docs branch September 9, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants