use tibble not data_frame

ropensci · Jul 4, 2018 · 7051b8f · 7051b8f
1 parent e43f180
commit 7051b8f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/R/internals.R b/R/internals.R
@@ -200,7 +200,7 @@ label_col_missing_pct <- function(x,
 #'
 #' @param x is a dataframe passed from vis_miss(x).
 #'
-#' @return a data_frame with two columns `p_miss_lab` and `p_pres_lab`,
+#' @return a tibble with two columns `p_miss_lab` and `p_pres_lab`,
 #'   containing the labels to use for present and missing. A dataframe is
 #'   returned because I think it is a good style habit compared to a list.
 #'
@@ -239,8 +239,8 @@ miss_guide_label <- function(x) {
                         sep = "")
   }
 
-  label_frame <- dplyr::data_frame(p_miss_lab = paste(p_miss_lab),
-                                   p_pres_lab = paste(p_pres_lab))
+  label_frame <- tibble::tibble(p_miss_lab = paste(p_miss_lab),
+                                p_pres_lab = paste(p_pres_lab))
 
   return(label_frame)
 

diff --git a/R/vis-compare.R b/R/vis-compare.R
@@ -36,8 +36,7 @@ vis_compare <- function(df1,
 
   v_identical <- Vectorize(identical)
 
-  df_diff <- purrr::map2(df1, df2, v_identical) %>%
-    dplyr::as_data_frame()
+  df_diff <- purrr::map2_df(df1, df2, v_identical)
 
   d <- df_diff %>%
     as.data.frame() %>%

diff --git a/man/miss_guide_label.Rd b/man/miss_guide_label.Rd
diff --git a/tests/testthat/test_variable_spaces.R b/tests/testthat/test_variable_spaces.R
@@ -2,10 +2,10 @@ context("Test names with spaces")
 
 library(visdat)
 
-messy_names <- dplyr::data_frame(`Sepal Width` = iris$Sepal.Width,
-                                 `Sepal Length` = iris$Sepal.Length,
-                                 `Petal Length` = iris$Petal.Length,
-                                 `Species Names` = iris$Species)
+messy_names <- tibble::tibble(`Sepal Width` = iris$Sepal.Width,
+                              `Sepal Length` = iris$Sepal.Length,
+                              `Petal Length` = iris$Petal.Length,
+                              `Species Names` = iris$Species)
 
 
 test_that("vis_dat works on dataframes with irregular variable names", {