Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the repos_file_branch macro and multiversion wf #307

Merged
merged 4 commits into from
May 14, 2024
Merged

Fix the repos_file_branch macro and multiversion wf #307

merged 4 commits into from
May 14, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented May 13, 2024 •
edited
Loading

  • otherwise the generated links were wrong in the jazzy version
  • multiversion workflow failed for PRs, because the base branch is not called "rolling" then

@christophfroehlich christophfroehlich changed the title Fix the repos_file_branch macro Fix the repos_file_branch macro and multiversion wf May 13, 2024
saikishor
saikishor requested changes May 14, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpicking change. Rest looks good to me. I recommend checking if these proposed changes work.

make_help_scripts/fix_index.py Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
make_help_scripts/fix_index.py Outdated Show resolved Hide resolved
@christophfroehlich @saikishor
Apply suggestions from code review
6ca3a5b 
Co-authored-by: Sai Kishor Kothakota <[email protected]>
@christophfroehlich
Copy link
Contributor Author

@saikishor CI is happy

saikishor
saikishor approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor merged commit 54d1641 into rolling May 14, 2024
5 checks passed
@saikishor saikishor deleted the fix_macro branch May 14, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @saikishor