Rename cartpole with cart #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
christophfroehlich
requested changes
Jan 3, 2024
There was a problem hiding this comment.
The changes here are missing (still referring to a cart-pole controller): https://github.com/ros-controls/gazebo_ros2_control/pull/252/files#diff-3161f66a61b9ed68303607f1dbdce1c7bdcc69c42f8ea1c2051a07a579ebcf5dR210-R217
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
christophfroehlich
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Sorry, but this is still not a valid ros2_control yaml (there is no type or write_op_modes parameter). Instead of the two code-blocks in L212,220, you could just use
.. literalinclude:: ../gz_ros2_control_demos/config/cart_controller_position.yaml
:language: yaml
|
Btw the "Check Docs" CI job fails because of another issue with control.ros.org |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
@christophfroehlich not really sure about how to solve this issue /home/runner/work/gz_ros2_control/gz_ros2_control/doc/acknowledgements/acknowledgements.rst:70: CRITICAL: Problems with "raw" directive path:
InputError: [Errno 2] No such file or directory: 'doc/acknowledgements/reviewers_stats.html'. |
christophfroehlich
approved these changes
Jan 3, 2024
As I said, a bug on control.ros.org -> I fixed it in the meantime. |
|
Thanks again for porting this to gz_ros2_control! |
|
thank you @christophfroehlich for pushing gazebo_ros2_control and gz_ros2_control |
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 7e388fa)
mergify bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 7e388fa) # Conflicts: # gz_ros2_control_demos/config/cartpole_controller_effort.yaml # gz_ros2_control_demos/config/cartpole_controller_position.yaml # gz_ros2_control_demos/config/cartpole_controller_velocity.yaml # gz_ros2_control_tests/urdf/test_cart_position.xacro.urdf # ign_ros2_control_demos/config/cart_controller_effort.yaml # ign_ros2_control_demos/config/cart_controller_position.yaml # ign_ros2_control_demos/config/cart_controller_velocity.yaml # ign_ros2_control_demos/config/cartpole_controller_effort.yaml # ign_ros2_control_demos/config/cartpole_controller_position.yaml # ign_ros2_control_demos/config/cartpole_controller_velocity.yaml # ign_ros2_control_demos/urdf/test_cart_effort.xacro.urdf # ign_ros2_control_demos/urdf/test_cart_position.xacro.urdf # ign_ros2_control_demos/urdf/test_cart_velocity.xacro.urdf
This was referenced Jan 4, 2024
ahcorde
added a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> (cherry picked from commit 7e388fa) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this PR in
gazebo_ros2_controlros-controls/gazebo_ros2_control#252