Don't crash if a wrong config was detected (backport #324) #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported with #323, the plugin crashes if there is a wrong config. On humble, the controller_manager tries to access unavailable state interfaces (I'll investigate more).
But also on rolling it crashes, despite the URDF parsers throws an error if a joint does not exists. The
configure()
method returns butPreUpdate
,PostUpdate
andDeconstructor
are accessing thethis->dataPtr->controller_manager_
gz_ros2_control/gz_ros2_control/src/gz_ros2_control_plugin.cpp
Lines 394 to 397 in 4503507
Is there maybe another way to deactivate the plugin properly and not even call the Update methods?
This is an automatic backport of pull request #324 done by Mergify.