Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash if a wrong config was detected (backport #324) #331

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 10, 2024

As reported with #323, the plugin crashes if there is a wrong config. On humble, the controller_manager tries to access unavailable state interfaces (I'll investigate more).

But also on rolling it crashes, despite the URDF parsers throws an error if a joint does not exists. The configure() method returns but PreUpdate, PostUpdate and Deconstructor are accessing the this->dataPtr->controller_manager_

RCLCPP_ERROR_STREAM(
this->dataPtr->node_->get_logger(),
"Error parsing URDF in gz_ros2_control plugin, plugin not active : " << ex.what());
return;

Is there maybe another way to deactivate the plugin properly and not even call the Update methods?


This is an automatic backport of pull request #324 done by Mergify.

@mergify mergify bot requested a review from ahcorde as a code owner June 10, 2024 07:49
@ahcorde ahcorde merged commit 0e0144a into jazzy Jun 10, 2024
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-324 branch June 10, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants