Use spawner with --params-file argument instead of cli verbs
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
saikishor
reviewed
Aug 24, 2024
Comment on lines
9
to
10
| ros__parameters: | ||
| joints: |
There was a problem hiding this comment.
Suggested change
| ros__parameters: | |
| joints: | |
| ros__parameters: | |
| type: velocity_controllers/JointGroupVelocityController | |
| joints: |
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 30e6705)
ahcorde
pushed a commit
that referenced
this pull request
Aug 26, 2024
…#409) Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 30e6705) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is now in line with the ros2_control_demo repo, especially ros-controls/ros2_control_demos#502
I tested all examples and fixed some other stuff (wrong topic for ackermann steering controller etc). I'll create a manual backport for iron.
Fixes #395