Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use reusable workflows and matrix strategy #151

Merged
merged 6 commits into from
Feb 17, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 11, 2024

The git diff is broken here unfortunately.

@bmagyar bmagyar merged commit e951a5d into master Feb 17, 2024
28 checks passed
@bmagyar bmagyar deleted the ci_reusable_wfs branch February 17, 2024 20:18
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments:

  • the ref_for_scheduled_build isn't strictly needed, since everything runs from the master branch, anyway, but it might be good to keep as a reminder
  • I do like the one matrix to rule them all approach, it's just sad that we cannot get individual badges per matrix entry... But especially since everything runs from the master branch, using one common workflow file rules out that disadvantage in my opinion.

Edit: Too slow...

@christophfroehlich
Copy link
Contributor Author

Looks good, just two minor comments:

* the `ref_for_scheduled_build` isn't strictly needed, since everything runs from the master branch, anyway, but it might be good to keep as a reminder

* I do like the one matrix to rule them all approach, it's just sad that we cannot get individual badges per matrix entry... But especially since everything runs from the master branch, using one common workflow file rules out that disadvantage in my opinion.

I agree with both. It's too easy to forget something when updating the individual workflows, that's why I vote for the matrix one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants